[coreboot-gerrit] Change in coreboot[master]: console/flashsconsole: Add spi flash console for debugging

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19849 )

Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/19849/2/src/console/Kconfig
File src/console/Kconfig:

Line 258: 	  region in the CBFS.
> I suppose you can keep it.
What do you mean with "custom fmd"? Just integrate this in the default FMAPs (which AFAIK are used by everything that's not defining CONFIG_CHROMEOS), then people can use it without knowing anything about FMAPs (other than that they need to use cbfstool read instead of cbfstool extract). I still think an FMAP region is a much better fit for this and there's no reason to add a new feature with two different but not really complementary ways of using it.

(The default FMAPs are in util/cbfstool/default[-x86].fmd and get their values from the top-level Makefile.inc.)


https://review.coreboot.org/#/c/19849/9/src/drivers/spi/flashconsole.c
File src/drivers/spi/flashconsole.c:

Line 51: 		cbfs_file_data(&cbfs_region, &file);
Please avoid prints in console init handlers unless it's a really important error... otherwise you will always have this line above the "coreboot-XXX <stage> starting..." banner, which is just weird.


Line 93: 			car_set_var(g_rdev, rdev);
Here as well (since due to the way the console fills up and has to be manually cleaned, this would be a pretty common condition).


Line 167
nit: just pull this into _tx_flush() so you don't need to have it twice?


-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes