[coreboot-gerrit] Change in coreboot[master]: purism/librem13v2: Add Kconfig defaults

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19942 )

Change subject: purism/librem13v2: Add Kconfig defaults
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19942/1/src/mainboard/purism/librem13v2/Kconfig
File src/mainboard/purism/librem13v2/Kconfig:

PS1, Line 76: 0x5c0000
> Why override the default defined in soc/intel/skylake?
The default is just a 'safe' default, but the CBFS_SIZE determines the size that CBFS can take without overlapping on the ME/descriptor. The flash is 16MB, there's 10MB used by the ME, and 256KB used by the AMI BIOS NVRAM storage (https://puri.sm/posts/preventing-interference-from-the-old-bios-while-flashing-coreboot/). If I keep it set to the default of 0x200000, it means that CBFS uses 2MB and there's a 4MB portion of the flash that is left unused.


-- 
To view, visit https://review.coreboot.org/19942
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6461cef78f3fea448baf1ada456e3c8335f1543
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-HasComments: Yes