[coreboot-gerrit] Change in coreboot[master]: purism/librem13v2: Don't disable PM timer

Youness Alaoui (Code Review) gerrit at coreboot.org
Fri May 26 23:50:40 CEST 2017


Hello Matt DeVillier,

I'd like you to do a code review.  Please visit

    https://review.coreboot.org/19938

to review the following change.


Change subject: purism/librem13v2: Don't disable PM timer
......................................................................

purism/librem13v2: Don't disable PM timer

Needed for UEFI booting via Tianocore;
with PM timer disabled, payload hangs.

Change-Id: I6c65cb9d3e6a10baea4cc1e2d9e94c36fe419561
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/mainboard/purism/librem13v2/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/19938/1

diff --git a/src/mainboard/purism/librem13v2/devicetree.cb b/src/mainboard/purism/librem13v2/devicetree.cb
index dc0655a..8f8dc92 100644
--- a/src/mainboard/purism/librem13v2/devicetree.cb
+++ b/src/mainboard/purism/librem13v2/devicetree.cb
@@ -57,7 +57,7 @@
 	register "PmConfigSlpS4MinAssert" = "1"        # 1s
 	register "PmConfigSlpSusMinAssert" = "1"       # 500ms
 	register "PmConfigSlpAMinAssert" = "3"         # 2s
-	register "PmTimerDisabled" = "1"
+	register "PmTimerDisabled" = "0"
 
 	register "pirqa_routing" = "PCH_IRQ11"
 	register "pirqb_routing" = "PCH_IRQ10"

-- 
To view, visit https://review.coreboot.org/19938
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c65cb9d3e6a10baea4cc1e2d9e94c36fe419561
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>



More information about the coreboot-gerrit mailing list