[coreboot-gerrit] Change in coreboot[master]: lib/edid: Split out fill_lb_framebuffer()

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19764 )

Change subject: lib/edid: Split out fill_lb_framebuffer()
......................................................................


Patch Set 6: Code-Review+1

Thanks, I'm okay with this as well. (I'm still not quite sure in what situation you think this is better than the weak symbol solution. Are you concerned about hypothetical platforms that could offer both native init and libgfxinit as choices? But then you just hide the source files that prove fill_lb_framebuffer() behind CONFIG_MAINBOARD_USE_LIBGFXINIT and it'll still work fine for either configuration? ...well, okay, as long as I don't have to select an extra option from every single ARM SoC I'm happy with it.)

-- 
To view, visit https://review.coreboot.org/19764
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90634b835bd8e2d150b1c714328a5b2774d891bd
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No