[coreboot-gerrit] Change in coreboot[master]: arm64: Align cache maintenance code with libpayload and ARM32

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19785 )

Change subject: arm64: Align cache maintenance code with libpayload and ARM32
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19785/1/src/arch/arm64/armv8/cache.c
File src/arch/arm64/armv8/cache.c:

Line 126: 	else if (sctlr & SCTLR_I)
> But isn't that happening with clean_invalidate_all() as well with the scena
> Or did you mean that since there are lines fetched from the instruction fetch sitting in l2 the caches need to be invalided to pick up the new instructions sitting in ram at the same address?

Yes, the invalidate is the important part so that instruction fetches see the new code that's only in RAM. Honestly, I'm not sure why this is clean_invalidate instead of just invalidate... it probably doesn't make a difference because without data caching the cache lines couldn't become dirty anyways, so the clean might be a no-op. This is just what the Qualcomm guy uploaded back then and said fixes the issue on his board that I don't have, so I'd rather unify the implementations on that now and it can still be revisited if we find issues with it in the future.


-- 
To view, visit https://review.coreboot.org/19785
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e05b425eeeaa27a447b37f98c0928fed3f74340
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes