[coreboot-gerrit] Change in coreboot[master]: nb/i945/raminit: Use common ddr2 decode functions

Arthur Heymans (Code Review) gerrit at coreboot.org
Fri May 26 13:30:48 CEST 2017


Hello Patrick Rudolph, build bot (Jenkins), coreboot org,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18305

to look at the new patch set (#37).

Change subject: nb/i945/raminit: Use common ddr2 decode functions
......................................................................

nb/i945/raminit: Use common ddr2 decode functions

This simplifies computing dram timings a lot.

This removes computation of rank size based on columns, rows,
banks,... and uses the information in SPD byte 31. The result of this
is that dimms with multiple asymmetric ranks are not supported
anymore. These however are very rare and most likely never tested on
this platform.

This also uses i2c block read instead of byte read to speed up the
raminit. The result is less time is being spend reading SPDs.
It still keeps smbus read byte as a backup if i2c block read were to
fail.

Change-Id: I97c93939d11807752797785dd88c70b43a236ee3
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/i945/raminit.c
M src/northbridge/intel/i945/raminit.h
2 files changed, 156 insertions(+), 614 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/18305/37
-- 
To view, visit https://review.coreboot.org/18305
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c93939d11807752797785dd88c70b43a236ee3
Gerrit-PatchSet: 37
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>



More information about the coreboot-gerrit mailing list