[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use common systemagent code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19795 )

Change subject: soc/intel/apollolake: Use common systemagent code
......................................................................


Patch Set 2:

(6 comments)

https://review.coreboot.org/#/c/19795/2/src/soc/intel/apollolake/northbridge.c
File src/soc/intel/apollolake/northbridge.c:

Line 27: struct sa_mmio_descriptor sa_fixed_resources[SOC_SA_FIXED_RESOURCES] = {
> const
Done


Line 32: struct sa_map_entry sa_memory_map[MAX_MAP_ENTRIES] = {
> const
Done


Line 40: struct sa_mmio_descriptor sa_imr_resources[SOC_SA_IMR_RESOURCES] = {
> const
Done


https://review.coreboot.org/#/c/19795/2/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

Line 84: 	struct sa_set_mmio_descriptor soc_fixed_set_resources[] = {
> const
Done


PS2, Line 85: \
> '\' no needed.
Done


Line 86: 				"MCHBAR"},
> Space after " and before }. Also, Same line?
Done


-- 
To view, visit https://review.coreboot.org/19795
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a3b2fc46ec9063b54379d41996b9a1d612cfd2
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes