[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Add detailed information about PME wake s...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19925 )

Change subject: soc/intel/skylake: Add detailed information about PME wake sources
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19925/2/src/soc/intel/skylake/elog.c
File src/soc/intel/skylake/elog.c:

Line 54: 	struct pme_status_info pme_status_info[] = {
> static const
Yeah, PCH_DEV_* does dev_find_slot. That's a good idea - I changed it to PCH_DEVFN_* and added check for NULL.


Line 55: 		{PCH_DEV_HDA, 0x54, ELOG_WAKE_SOURCE_PME_HDA},
> spaces after { and before }
Done


-- 
To view, visit https://review.coreboot.org/19925
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc6284cd04db311f1f86b8a86d0bb708392e5d5
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes