[coreboot-gerrit] Change in coreboot[master]: nb/x4x/raminit: Rewrite SPD decode and timing selection

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19143 )

Change subject: nb/x4x/raminit: Rewrite SPD decode and timing selection
......................................................................


Patch Set 18:

(1 comment)

https://review.coreboot.org/#/c/19143/16/src/northbridge/intel/x4x/raminit.c
File src/northbridge/intel/x4x/raminit.c:

Line 256: 	u8 dimm_mask = 0;
> thx, not sure if it properly returns failure but I'll definitly check it ou
does not work sadly...


-- 
To view, visit https://review.coreboot.org/19143
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071
Gerrit-PatchSet: 18
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: Yes