[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add CPU files

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/19723 )

Change subject: soc/amd/stoneyridge: Add CPU files
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/19723/3/src/northbridge/amd/pi/Kconfig
File src/northbridge/amd/pi/Kconfig:

Line 19: 	default y if SOC_AMD_PI
> Agreed - If we're moving things to SOC, why would we still need pieces in s
yes, the northbridge is the next patch and this was needed to check the build and code worked moving the CPU code.


https://review.coreboot.org/#/c/19723/3/src/soc/amd/common/Kconfig
File src/soc/amd/common/Kconfig:

Line 13
> But that doesn't really fix the problem entirely. Someone still has to incl
So is there a solution already figured out or we should be doing something completely different here?


-- 
To view, visit https://review.coreboot.org/19723
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6b1991372c2c6a02709777a73615a86e78ac26
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes