[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Use MCH_BASE_ADDRESS macro for APL

Subrata Banik (Code Review) gerrit at coreboot.org
Thu May 25 10:46:47 CEST 2017


Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19793 )

Change subject: soc/intel/apollolake: Use MCH_BASE_ADDRESS macro for APL
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/19793/2/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

Line 144: 		0x0);
> same line
Done


Line 147: 				       BIOS_RESET_CPL);
> same line
Done


-- 
To view, visit https://review.coreboot.org/19793
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iace1cf786b08221c3955101186509ac5161c3841
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list