[coreboot-gerrit] Change in coreboot[master]: google/gru: enable the pull high for touchpad

[Caesar Wang (Code Review)]

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 )

Change subject: google/gru: enable the pull high for touchpad
......................................................................


Patch Set 2:

(1 comment)

> (1 comment)
 > 
 > ```
 > WARNING: please, no spaces at the start of a line
 > #11: FILE: src/mainboard/google/gru/romstage.c:72:
 > +       gpio_output(GPIO(3, B, 4), 1); /* Pull high for TP */$
 > 
 > total: 0 errors, 1 warnings, 19 lines checked
 > + true
 > ```


Sorry, done.

https://review.coreboot.org/#/c/19863/1//COMMIT_MSG
Commit Message:

PS1, Line 19: firmware
> Please mention the firmware versions.
Done. I'm no sure what's finial version in the end. (just supply the firmware for tests)

I *think* this patch is independent, that's no depend on the Elan firmware.


-- 
To view, visit https://review.coreboot.org/19863
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes