[coreboot-gerrit] Change in coreboot[master]: google/gru: enable the pull high for touchpad

Caesar Wang (Code Review) gerrit at coreboot.org
Thu May 25 04:23:39 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19863

to look at the new patch set (#2).

Change subject: google/gru: enable the pull high for touchpad
......................................................................

google/gru: enable the pull high for touchpad

As the hardware designed on gru, the AP_I2C_TP_PU_EN (gpio3_b4) controlled
the SCL/SDA status to avoid leakage.

As the gpio3_b4 of rk3399 pull resistor is 26k~71k and 3.3v for supply
power, and gpio3_b4 pin connected 2.2k resistor to i2c of TP device.

The default of this gpio status is output high during the start to bootup,
it's very weak drive for the TP device that maybe cause to trigger the
recovery process of elan touchpad.

Also, the Elan updated their firmware(102.0.5.0) to delay checking the i2c
of touchpad.

Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Signed-off-by: Caesar Wang <wxt at rock-chips.com>
---
M src/mainboard/google/gru/romstage.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/19863/2
-- 
To view, visit https://review.coreboot.org/19863
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a67d1c041afafde24ed9f00716ba41a9b41a8da
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list