[coreboot-gerrit] Change in coreboot[master]: console/flashsconsole: Add spi flash console for debugging

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19849 )

Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................


Patch Set 6:

(4 comments)

https://review.coreboot.org/#/c/19849/5/src/drivers/spi/flashconsole.c
File src/drivers/spi/flashconsole.c:

PS5, Line 18: #include <boot_device.h>
> This isn't needed.
boot_device_rw() is defined there.


PS5, Line 24: #include <spi_flash.h>
> This isn't needed.
Done


PS5, Line 26: 0x1000
> This is pretty big, fwiw. Some people might run out of CAR space.  You prob
yeah, it was 0x100, then I changed it to 0x1000 when I started using that buffer to read the sectors to find 0xff. I should probably dial it down back down to 0x100 (or 128? biggest line I found in my log is 113 bytes), and use a local buffer in the init for the sectors.


PS5, Line 149: || 
> This should just remove the -1 as we'll flush when we reach full capacity. 
Yeah, leftover from when I was using a '\0' to find the size of the line.


-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes