[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8/h8: Always enable tp-smapi and thermal

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded a new change for review. ( https://review.coreboot.org/19864 )

Change subject: ec/lenovo/h8/h8: Always enable tp-smapi and thermal
......................................................................

ec/lenovo/h8/h8: Always enable tp-smapi and thermal

Always enable tp-smapi and thermal managment.
It should always be enabled as the SMM code relies on it.

Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/ec/lenovo/h8/h8.c
1 file changed, 9 insertions(+), 5 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/19864/1

diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index b259d9a..5ea4a2c 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -209,21 +209,25 @@
 {
 	struct ec_lenovo_h8_config *conf = dev->chip_info;
 	u8 val;
-	u8 beepmask0, beepmask1, config1;
+	u8 beepmask0, beepmask1, reg8;
 
 	dev->ops = &h8_dev_ops;
 
 	h8_log_ec_version();
 
-	ec_write(H8_CONFIG0, conf->config0);
-	config1 = conf->config1;
+	/* Always enable I/O range 0x1600-0x160f and thermal management */
+	reg8 = conf->config0;
+	reg8 |= H8_CONFIG0_SMM_H8_ENABLE;
+	reg8 |= H8_CONFIG0_TC_ENABLE;
+	ec_write(H8_CONFIG0, reg8);
 
+	reg8 = conf->config1;
 	if (conf->has_keyboard_backlight) {
 		if (get_option(&val, "backlight") != CB_SUCCESS)
 			val = 0; /* Both backlights.  */
-		config1 = (config1 & 0xf3) | ((val & 0x3) << 2);
+		reg8 = (reg8 & 0xf3) | ((val & 0x3) << 2);
 	}
-	ec_write(H8_CONFIG1, config1);
+	ec_write(H8_CONFIG1, reg8);
 	ec_write(H8_CONFIG2, conf->config2);
 	ec_write(H8_CONFIG3, conf->config3);
 

-- 
To view, visit https://review.coreboot.org/19864
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5aa50e0b1148a7cc8e51480623368ee62edb849
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>