[coreboot-gerrit] Change in coreboot[master]: CBMEM: Clarify CBMEM_TOP_BACKUP function usage
Philippe Mathieu-Daudé (Code Review)
gerrit at coreboot.org
Wed May 24 17:45:06 CEST 2017
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19377 )
Change subject: CBMEM: Clarify CBMEM_TOP_BACKUP function usage
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/19377/6/src/cpu/amd/mtrr/amd_mtrr.c
File src/cpu/amd/mtrr/amd_mtrr.c:
PS6, Line 83: uint32_t
it makes sens to me to use uintptr_t in this function now.
--
To view, visit https://review.coreboot.org/19377
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61d20f94840ad61e9fd55976e5aa8c27040b8fb7
Gerrit-PatchSet: 6
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list