[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Initialise async variable

Martin Roth (Code Review) gerrit at coreboot.org
Wed May 24 16:28:16 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19736 )

Change subject: nb/intel/x4x/raminit: Initialise async variable
......................................................................


Patch Set 1: Code-Review+2

I agree that the commit message could be worded better, but I don't think it's a big issue.  It covers the important part which is that the variable needed to be initialized.

-- 
To view, visit https://review.coreboot.org/19736
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3be9477d836123aaa87c9bebb41c1ec34689a771
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list