[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/19603 )

Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................


Patch Set 50:

(12 comments)

https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:

PS50, Line 9: select SOC_INTEL_APOLLOLAKE
Would it be better to not select SOC_INTEL_APOLLOLAKE and use  "if SOC_INTEL_APOLLOLAKE || SOC_INTEL_GLK" where needed?


PS50, Line 294: 	default CAR_CQOS if !SOC_INTEL_GLK
              : 	default CAR_NEM if SOC_INTEL_GLK
Maybe get rid of the second if?
	default CAR_NEM if SOC_INTEL_GLK
	default CAR_CQOS


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/gpio_apl.asl
File src/soc/intel/apollolake/acpi/gpio_apl.asl:

Line 203: 
extra line


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/gpio_glk.asl
File src/soc/intel/apollolake/acpi/gpio_glk.asl:

Line 22: 
extra line


Line 208: 
extra line


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/lpc_glk.asl
File src/soc/intel/apollolake/acpi/lpc_glk.asl:

PS50, Line 25:   Device (HPET)
             :         {
indent this file with tabs instead of spaces?


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/acpi/lpss_glk.asl
File src/soc/intel/apollolake/acpi/lpss_glk.asl:

Line 159: 
extra line


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/soc/gpio_glk.h
File src/soc/intel/apollolake/include/soc/gpio_glk.h:

PS50, Line 367: GLk
use caps?


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/soc/pci_ids.h
File src/soc/intel/apollolake/include/soc/pci_ids.h:

PS50, Line 22: _SOC_APOLLOLAKE_PCI_IDS_H_
change to match the define?


Line 23: 
extra line


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:

Line 139: 
Get rid of the preprocessor #if and just return false here if it's GLC?

 if (IS_ENABLED(CONFIG_SOC_INTEL_GLK))
     return false;


PS50, Line 347: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK) /* TODO */
Please use a C if statement unless the preprocessor if is specifically needed.


-- 
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 50
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong at intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson at intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93 at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes