[coreboot-gerrit] Change in coreboot[master]: intel/common/block/i2c: Add common block for I2C and use the...

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19468 )

Change subject: intel/common/block/i2c: Add common block for I2C and use the same in SoCs
......................................................................


Patch Set 14:

(1 comment)

> > (1 comment)
 > >
 > > > > This is causing a boot regression. Was it tested on
 > apollolake
 > > > > boards?
 > > >
 > > > is that during PCI enumeration at device 18:01 something, i
 > have
 > > > also seen it 1-2 days before but wondering why others haven't
 > > > reported the same hang. Hence i thought something bad about my
 > > > setup.
 > >
 > > Yes.
 > 
 > i guess it started regressing from patchset 7.

We also saw a issue in GLK and added 19782 which had the array termination which solved the problem

https://review.coreboot.org/#/c/19468/14/src/soc/intel/common/block/i2c/i2c.c
File src/soc/intel/common/block/i2c/i2c.c:

Line 176: 	PCI_DEVICE_ID_INTEL_APL_I2C7,
> This should have been terminated with a 0.
This patch is missing what was added in 19782


-- 
To view, visit https://review.coreboot.org/19468
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d91a04c22e181e3a995112cce6d5f0324130b81
Gerrit-PatchSet: 14
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes