[coreboot-gerrit] Change in coreboot[master]: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed May 24 04:43:52 CEST 2017
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/19781 )
Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
......................................................................
drivers/spi/spi-generic: Make spi_setup_slave strong symbol
Now that all platforms are updated to provide spi bus map, there is no
need to keep the spi_setup_slave as a weak symbol.
BUG=b:38430839
Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
Reviewed-on: https://review.coreboot.org/19781
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/drivers/spi/spi-generic.c
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Aaron Durbin: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/drivers/spi/spi-generic.c b/src/drivers/spi/spi-generic.c
index 579ceb1..31a6bc3 100644
--- a/src/drivers/spi/spi-generic.c
+++ b/src/drivers/spi/spi-generic.c
@@ -112,11 +112,7 @@
/* Default weak implementation - do nothing. */
}
-const struct spi_ctrlr_buses spi_ctrlr_bus_map[0] __attribute__((weak));
-const size_t spi_ctrlr_bus_map_count __attribute__((weak));
-
-int __attribute__((weak)) spi_setup_slave(unsigned int bus, unsigned int cs,
- struct spi_slave *slave)
+int spi_setup_slave(unsigned int bus, unsigned int cs, struct spi_slave *slave)
{
size_t i;
--
To view, visit https://review.coreboot.org/19781
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
More information about the coreboot-gerrit
mailing list