[coreboot-gerrit] Change in coreboot[master]: console/flashsconsole: Adding a spi flash console for debugging

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19849 )

Change subject: console/flashsconsole: Adding a spi flash console for debugging
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19849/2/src/include/console/flash.h
File src/include/console/flash.h:

Line 25: #define __CONSOLE_FLASH_ENABLE__	IS_ENABLED(CONFIG_CONSOLE_SPI_FLASH)
> That's the way the console stuff is plugged in. See the rest of the console
Some consoles do this to define a shorthand for a complex expression, but not all of them (e.g. spkmodem or ne2k). It's not used outside this file and the expression is not complex, so I thought it didn't add much.


-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes