[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block:[WIP] Add GPIO common code

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/18917 )

Change subject: soc/intel/common/block:[WIP] Add GPIO common code
......................................................................


Patch Set 34:

> > (1 comment)
 > >
 > > > (19 comments)
 > > >
 > > > I haven't gotten into the headers fully, but I find this hard
 > to
 > > > review. Can we do the following?
 > > >
 > > > Start with apollolake, move it the implementation over in one
 > > full
 > > > swoop and have apollolake use it. Then start making the
 > > > modifications necessary to incorporate handling additional
 > SoCs.
 > > > That way it's really easy to identify the surface area of the
 > SoC
 > > > vs the common. What do you think?
 > > >
 > > > One of the major pain points is that it seems like some code
 > was
 > > > just changed just for the sake of it compared to the baseline.
 > > > That's just really hard to swallow when trying to compare
 > > > implementations.
 > >
 > > I moved the macro definitions as is from apollolake and added
 > some
 > > more specifically for IOStandby.
 > > WHich functions are you saying have got changed from baseline ?
 > 
 > I'm comparing gpio.c to apollolakes and there's all kinds of subtle
 > changes to working code that seems to be broken now. Basically I'm
 > proposing start with apl code. Then start adding in the APIs that
 > you're proposing in here to decouple it from apl proper. That gives
 > us the benefit of knowing that the code worked plus we can see the
 > surface area of the changes required to accommodate more than one
 > SoC. What we have now is both of those combined plus other edits
 > which seems to have broken the logic as well as things that didn't
 > need to be changed at all. It makes for reviewing hard and will
 > cause bugs to be introduced.
 > 
 > It should be easier to layer in the SoC decoupling patches on top
 > of apollolake base line to properly assess the changes.

OK I will take APL gpio.c

-- 
To view, visit https://review.coreboot.org/18917
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1d56df46668bfb08206ca4a99202db5cd1da7c
Gerrit-PatchSet: 34
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at gmail.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong at intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson at intel.com>
Gerrit-Reviewer: Dhaval Sharma <dhaval.v.sharma at intel.com>
Gerrit-Reviewer: Divya Chellappa <divya.chellappa at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93 at gmail.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: sowmya v <sowmyav235 at gmail.com>
Gerrit-HasComments: No