[coreboot-gerrit] Change in coreboot[master]: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER

Julius Werner (Code Review) gerrit at coreboot.org
Tue May 23 04:34:00 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/19800 )

Change subject: Kconfig: Introduce HAVE_(VBE_)LINEAR_FRAMEBUFFER
......................................................................


Patch Set 7: Code-Review+1

I think this should be okay for the ARM boards, but a better solution would be to fix t124 and rk3288 to also check for MAINBOARD_DO_NATIVE_VGA_INIT in soc_init(). It just wasn't implemented right back in the day. Or maybe we should just roll that check into display_init_required(), then we automatically get it everywhere.

-- 
To view, visit https://review.coreboot.org/19800
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff6dac5a5f61af49456bc6312e7a376def02ab00
Gerrit-PatchSet: 7
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list