[coreboot-gerrit] Change in coreboot[master]: drivers/spi/spi-generic: Make spi_setup_slave strong symbol

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon May 22 22:55:54 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19781 )

Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19781/3/src/drivers/spi/spi-generic.c
File src/drivers/spi/spi-generic.c:

Line 116: const size_t spi_ctrlr_bus_map_count __attribute__((weak));
> We should delete this as well, I think. If spi is supposed to work there sh
Yes, that makes sense. Will push a new patchset.


-- 
To view, visit https://review.coreboot.org/19781
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list