[coreboot-gerrit] Change in coreboot[master]: soc/marvell/armada38x: Move spi driver to use spi_bus_map

Furquan Shaikh (Code Review) gerrit at coreboot.org
Mon May 22 22:53:37 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19774 )

Change subject: soc/marvell/armada38x: Move spi driver to use spi_bus_map
......................................................................


Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/19774/3/src/soc/marvell/armada38x/spi.c
File src/soc/marvell/armada38x/spi.c:

Line 492: 		.bus_end = 1,
> How do you actually know there are 2 buses? I can't for the life of me figu
Yeah, it is a bit tricky since none of the mainboards actually use this SoC. I looked up the datasheet for the SoC here:https://www.marvell.com/embedded-processors/armada-38x/ and found that it refers to two SPI ports 0 and 1 in the hardware spec and the functional spec provides register definitions for two SPI controllers SPI0 and SPI1.


-- 
To view, visit https://review.coreboot.org/19774
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795ecd825d03a3a915222da5e920bfd581567d5f
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list