[coreboot-gerrit] Change in coreboot[master]: mb/asus/kgpe-d16: Add BMC KCS to ACPI

Timothy Pearson (Code Review) gerrit at coreboot.org
Mon May 22 20:17:21 CEST 2017


Timothy Pearson has uploaded a new change for review. ( https://review.coreboot.org/19822 )

Change subject: mb/asus/kgpe-d16: Add BMC KCS to ACPI
......................................................................

mb/asus/kgpe-d16: Add BMC KCS to ACPI

The BMC KCS interface must be advertised to the host OS in order
for automatic load of the ipmi module to work.  Expose the KCS
interface via ACPI.

Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac7
Signed-off-by: Timothy Pearson <tpearson at raptorengineering.com>
---
M src/mainboard/asus/kgpe-d16/dsdt.asl
1 file changed, 31 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/19822/1

diff --git a/src/mainboard/asus/kgpe-d16/dsdt.asl b/src/mainboard/asus/kgpe-d16/dsdt.asl
index a1eda28..38bcf98 100644
--- a/src/mainboard/asus/kgpe-d16/dsdt.asl
+++ b/src/mainboard/asus/kgpe-d16/dsdt.asl
@@ -50,6 +50,9 @@
 	/* HPET enable */
 	Name (HPTE, 0x1)
 
+	/* IPMI KCS enable */
+	Name (KCSE, 0x1)
+
 	/* Define power states */
 	Name (\_S0, Package () { 0x00, 0x00, 0x00, 0x00 })	/* Normal operation */
 	Name (\_S1, Package () { 0x01, 0x01, 0x00, 0x00 })	/* Standby */
@@ -490,6 +493,13 @@
 				Name (_HID, EisaId ("PNP0A05"))
 				Name (_ADR, 0x00140003)
 
+				OperationRegion(BMRG, SystemIO, 0xca2, 0x02) /* BMC KCS registers */
+					Field(BMRG, AnyAcc, NoLock, Preserve)
+				{
+					BMRI, 8,	/* Index */
+					BMRD, 8,	/* Data */
+				}
+
 				/* Real Time Clock Device */
 				Device(RTC0) {
 					Name(_HID, EISAID("PNP0B00"))   /* AT Real Time Clock (not PIIX4 compatible) */
@@ -611,6 +621,27 @@
 						})
 					}
 				}
+
+				Device(KCS1) {   /* IPMI KCS */
+					Name(_HID,EISAID("IPI0001"))		/* ASpeed BMC */
+					Method (_STA, 0, NotSerialized) {
+						If(KCSE) {			/* Detection enabled */
+							If(LNotEqual(BMRD, 0xff)) {
+								Return(0x0f)	/* Device present */
+							}
+							Return(Zero)
+						}
+						Return(Zero)
+					}
+					Method(_CRS, 0) {
+						Return(ResourceTemplate() {
+							IO(Decode16, 0x0ca2, 0x0ca2, 0x01, 0x02)
+						})
+					}
+					Method (_IFT, 0, NotSerialized) {	/* Interface type */
+						Return(One)			/* KCS interface */
+					}
+				}
 			}
 
 			/* High Precision Event Timer */

-- 
To view, visit https://review.coreboot.org/19822
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac7
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Timothy Pearson <tpearson at raptorengineering.com>



More information about the coreboot-gerrit mailing list