[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Use a struct for dll settings instead of an array

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon May 22 09:03:15 CEST 2017


Hello Patrick Rudolph, Philippe Mathieu-Daudé, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19767

to look at the new patch set (#3).

Change subject: nb/intel/x4x: Use a struct for dll settings instead of an array
......................................................................

nb/intel/x4x: Use a struct for dll settings instead of an array

This makes the code more readable since it avoids messing with two
dimensional arrays and needing remember what the indices mean.

Also introduces an unused coarse element which is 0 for all default
DLL settings on DDR2.

Change-Id: I28377d2d15d0e6a0d12545b837d6369e0dc26b92
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/raminit_ddr2.c
M src/northbridge/intel/x4x/x4x.h
2 files changed, 113 insertions(+), 104 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/19767/3
-- 
To view, visit https://review.coreboot.org/19767
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28377d2d15d0e6a0d12545b837d6369e0dc26b92
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list