[coreboot-gerrit] Change in coreboot[master]: mb/lenvovo/*: Clean mainboard.c and devicetree

Patrick Rudolph (Code Review) gerrit at coreboot.org
Sun May 21 15:48:59 CEST 2017


Hello Arthur Heymans, Paul Menzel, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19494

to look at the new patch set (#8).

Change subject: mb/lenvovo/*: Clean mainboard.c and devicetree
......................................................................

mb/lenvovo/*: Clean mainboard.c and devicetree

* Move board specific SPI registers to devicetree
* Remove unused headers
* Remove obsolete methods
* Fix coding style
* Fix Thinkpad L520 SPI lvscc register

Except for Thinkpad L520, no functional change has been done,
just moving stuff around.

Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
M src/mainboard/lenovo/l520/devicetree.cb
M src/mainboard/lenovo/l520/mainboard.c
M src/mainboard/lenovo/s230u/devicetree.cb
M src/mainboard/lenovo/s230u/mainboard.c
M src/mainboard/lenovo/t400/mainboard.c
M src/mainboard/lenovo/t420/devicetree.cb
M src/mainboard/lenovo/t420/mainboard.c
M src/mainboard/lenovo/t420s/devicetree.cb
M src/mainboard/lenovo/t420s/mainboard.c
M src/mainboard/lenovo/t430s/devicetree.cb
M src/mainboard/lenovo/t430s/mainboard.c
M src/mainboard/lenovo/t520/devicetree.cb
M src/mainboard/lenovo/t520/mainboard.c
M src/mainboard/lenovo/t530/devicetree.cb
M src/mainboard/lenovo/t530/mainboard.c
M src/mainboard/lenovo/t60/mainboard.c
M src/mainboard/lenovo/x1_carbon_gen1/devicetree.cb
M src/mainboard/lenovo/x1_carbon_gen1/mainboard.c
M src/mainboard/lenovo/x200/mainboard.c
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/lenovo/x220/devicetree.cb
M src/mainboard/lenovo/x220/mainboard.c
M src/mainboard/lenovo/x230/devicetree.cb
M src/mainboard/lenovo/x230/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
25 files changed, 110 insertions(+), 278 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/19494/8
-- 
To view, visit https://review.coreboot.org/19494
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I692a5632030fe2fedbe9a90f86251000f1360fb2
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list