[coreboot-gerrit] Change in coreboot[master]: nb/intel/ivybridge: Improve CAS freq selection

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19717 )

Change subject: nb/intel/ivybridge: Improve CAS freq selection
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/19717/1/src/northbridge/intel/sandybridge/raminit_ivy.c
File src/northbridge/intel/sandybridge/raminit_ivy.c:

Line 327: 		ctrl->tCK = 0;
> Please set `base_freq` too, to make it clear that the recursion breaks.
ok.


Line 349: 		   ref_100mhz_support ? "yes" : "no");
> This is now printed everytime this gets called. Why not keep the
ok


Line 366: 			ivb_normalize_tclk(ctrl, ref_100mhz_support);
> What happens after this line?
hmm it should not normalise since this is done at the beginning of the loop...

I'll add a comment to clarify the code flow


PS1, Line 373: (1000 << 8)
> This should be a defined value...
ok


-- 
To view, visit https://review.coreboot.org/19717
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1df20a0a723dc515686a766ad1b0567d815f6e89
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes