[coreboot-gerrit] Change in coreboot[master]: nb/x4x/raminit: Rewrite SPD decode and timing selection

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19143 )

Change subject: nb/x4x/raminit: Rewrite SPD decode and timing selection
......................................................................


Patch Set 16:

(4 comments)

https://review.coreboot.org/#/c/19143/16/src/northbridge/intel/x4x/raminit.c
File src/northbridge/intel/x4x/raminit.c:

Line 88: 		s->selected_timings.mem_clk = MEM_CLOCK_400MHz; break;
is it allowed ? I thought checkpatch complains about that.
Please use the same style in all switch case blocks.


Line 121: static int ddr2_save_dimminfo(u8 dimm_idx, u8 *raw_spd,
return enum cb_err ?


Line 254: 	if (block_read)	{
space


Line 256: 		i2c_block_read(device, 0, num_bytes, raw_spd);
fallback to spd_read_byte if i2c_block_read returns a failure ?


-- 
To view, visit https://review.coreboot.org/19143
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I760eeaa3bd4f2bc25a517ddb1b9533c971454071
Gerrit-PatchSet: 16
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: coreboot org <coreboot.org at gmail.com>
Gerrit-HasComments: Yes