[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
Julius Werner (Code Review)
gerrit at coreboot.org
Sat May 20 07:58:29 CEST 2017
Julius Werner has posted comments on this change. ( https://review.coreboot.org/19770 )
Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/19770/3/src/soc/mediatek/mt8173/spi.c
File src/soc/mediatek/mt8173/spi.c:
Line 305: .max_xfer_size = 65535,
Actually all of the above don't matter anyway because it's a programmer-speicfic probe that will overwrite read/write/erase directly. Some of them (e.g. claim/release) are completely wrong and would do bad things if they ever actually got called. Maybe better to leave them NULL?
--
To view, visit https://review.coreboot.org/19770
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list