[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map

Furquan Shaikh (Code Review) gerrit at coreboot.org
Sat May 20 01:48:57 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19770 )

Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19770/1/src/soc/mediatek/mt8173/spi.c
File src/soc/mediatek/mt8173/spi.c:

Line 333: 		.bus_end = CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS,
> I'm just suggesting to replace this with a literal 0 for now. That will com
Sounds good. I will change spi_ec_ctrlr to 0 and keep spi_flash_ctrlr as is.


-- 
To view, visit https://review.coreboot.org/19770
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list