[coreboot-gerrit] Change in coreboot[master]: arch/x86: Add function to determine if we're currently runni...

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19787 )

Change subject: arch/x86: Add function to determine if we're currently running from CAR
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19787/1/src/arch/x86/include/arch/early_variables.h
File src/arch/x86/include/arch/early_variables.h:

Line 50: 	return 1;
> Hmm.. I thought latest intel's don't use cache-as-ram at all?
Uhh... I'm not really the expert on that tbh. I think they still use CAR but they don't do CAR migration anymore, or something? (Looks like NO_CAR_GLOBAL_MIGRATION is selected by default for all boards with POSTCAR_STAGE, which would substantiate this. That would mean those boards always return 1 for bootblock/verstage/romstage and 0 for postcar/ramstage in this function, which would be working as intended.)


https://review.coreboot.org/#/c/19787/1/src/cpu/x86/car.c
File src/cpu/x86/car.c:

Line 118: 	return !!car_migrated;
> Yes, it should be. ~0 is migrated. 0 is not-migrated.
Whoops, right, sorry, will fix.


-- 
To view, visit https://review.coreboot.org/19787
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7ad0896a691ef6e89e622b985417fedc43579c1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes