[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8173: Move spi driver to use spi_bus_map

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19770 )

Change subject: soc/mediatek/mt8173: Move spi driver to use spi_bus_map
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/19770/1/src/soc/mediatek/mt8173/spi.c
File src/soc/mediatek/mt8173/spi.c:

Line 304: 	default:
> Can take out the flash and the "wrong number" case now because generic code
Yeah, that makes sense.


PS1, Line 311: spi_ctrlr_setup
> Should be NULL?
Yeah, then we can get rid of the case for SPI_FLASH_BUS above.


PS1, Line 331: ec
> Shouldn't have "ec" in the name in this file. Just spi_ctrlr.
Sounds good.


Line 333: 		.bus_end = CONFIG_EC_GOOGLE_CHROMEEC_SPI_BUS,
> I guess it was never really a great idea to put this Kconfig in here becaus
Yeah, I just tried to keep the changes as minimal as possible from the original logic. Are you suggesting that spi_ctrlr have bus #0 and flash bus #1? But then would we still be providing boards to select bus #? The reason I used the config here is to make sure the expectations matches what the board selected.


-- 
To view, visit https://review.coreboot.org/19770
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d6e4e8185ce1285b671af5ebcead1d42e049bc
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes