[coreboot-gerrit] Change in coreboot[master]: soc/rockchip: Move spi driver to use spi_bus_map

Julius Werner (Code Review) gerrit at coreboot.org
Fri May 19 23:56:47 CEST 2017


Julius Werner has posted comments on this change. ( https://review.coreboot.org/19771 )

Change subject: soc/rockchip: Move spi driver to use spi_bus_map
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/19771/1/src/soc/rockchip/common/spi.c
File src/soc/rockchip/common/spi.c:

Line 328: 	assert(slave->bus < ARRAY_SIZE(rockchip_spi_slaves));
nit: unnecessary, already guaranteed by framework now?


-- 
To view, visit https://review.coreboot.org/19771
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b1b9635ece2381f62f2a9d6f5744d639d59163
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list