[coreboot-gerrit] Change in coreboot[master]: detachables: Add invert parameter

[Shelley Chen (Code Review)]

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/19698 )

Change subject: detachables: Add invert parameter
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/19698/8/payloads/libpayload/drivers/video/graphics.c
File payloads/libpayload/drivers/video/graphics.c:

PS8, Line 122: 00
> Does the upper byte not matter?
I did this thinking each red, green, blue is a uint8_t value,  so we don't actually set the top 8 bits. I didn't want to mess with the upper bits because we weren't actually setting them, but I just tried it and it didn't change the functionality.  I suppose that if we ever change the layout of the color bits, having all Fs would make this function more flexible?  Anyway, I changed it to all Fs. :)


-- 
To view, visit https://review.coreboot.org/19698
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6893a26f19eb2490377d4d53366ad145a9e6e3
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes