[coreboot-gerrit] Change in coreboot[master]: google/fizz: Set PL2 to 29 Watts
Rajat Jain (Code Review)
gerrit at coreboot.org
Fri May 19 01:43:41 CEST 2017
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/19783 )
Change subject: google/fizz: Set PL2 to 29 Watts
......................................................................
Patch Set 1:
Er, I think this can't be a static value, we need to set this differently based on different things. (https://b.corp.google.com/issues/37473486#comment5)
- This will be different for different Fizz SKU(s).
- Also need to ask EC what is the power source (barrel jack / USB type C)
- If type C, need to ask EC what is the adapter rating and decide this value accordingly.
Also, if this (static value) was meant for all SKUs, I think this is pretty low for higher end SKUs.
--
To view, visit https://review.coreboot.org/19783
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie152961ea38dce228efac2117928305586120709
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list