[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add northbridge support

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19724 )

Change subject: soc/amd/stoneyridge: Add northbridge support
......................................................................


Patch Set 2:

(2 comments)

Same complaint as "CPU files" patch regarding BiosCallOuts.h.

https://review.coreboot.org/#/c/19724/2/src/soc/amd/common/agesawrapper.c
File src/soc/amd/common/agesawrapper.c:

PS2, Line 23: #include <northbridge/amd/pi/agesawrapper.h>
            : #include <northbridge/amd/pi/BiosCallOuts.h>
Missed these two.

 #include <agesawrapper.h>
 #include <soc/amd/common/BiosCallOuts.h>


https://review.coreboot.org/#/c/19724/2/src/soc/amd/stoneyridge/dimmSpd.c
File src/soc/amd/stoneyridge/dimmSpd.c:

PS2, Line 21: #include "Porting.h"
            : #include "AGESA.h"
            : #include "amdlib.h"
            : #include "chip.h"
            : #include "northbridge/amd/pi/dimmSpd.h"
#include <Porting.h>
#include <AGESA.h>
#include <amdlib.h>
#include <dimmSpd.h>
#include "chip.h"


-- 
To view, visit https://review.coreboot.org/19724
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86b4d744900f23502068517ece5bcea6c128993
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes