[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add CPU files

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19723 )

Change subject: soc/amd/stoneyridge: Add CPU files
......................................................................


Patch Set 2:

(1 comment)

Other files could probably benefit from the same include file cleanup, but this one's pointing at the wrong BiosCallOuts.h.

Also, it would be nice to shorten that, i.e. remove the pathname, but mainboard directory is getting -I included first and it also contains a BiosCallOuts.h.

https://review.coreboot.org/#/c/19723/2/src/soc/amd/common/heapmanager.c
File src/soc/amd/common/heapmanager.c:

PS2, Line 15: #include "AGESA.h"
            : #include "amdlib.h"
            : #include <northbridge/amd/pi/BiosCallOuts.h>
            : #include "heapManager.h"
#include <AGESA.h>
#include <amdlib.h>
#include <soc/amd/common/BiosCallOuts.h>
#include <heapManager.h>

Also, we've talked about my preference for putting AMD stuff after other includes (the ones below).


-- 
To view, visit https://review.coreboot.org/19723
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6b1991372c2c6a02709777a73615a86e78ac26
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes