[coreboot-gerrit] Change in coreboot[master]: soc: Add AMD StoneyRidge southbridge code

Marshall Dawson (Code Review) gerrit at coreboot.org
Thu May 18 23:33:06 CEST 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19722 )

Change subject: soc: Add AMD StoneyRidge southbridge code
......................................................................


Patch Set 2:

(1 comment)

Other files could likely benefit from similar include file cleanup, but we'd missed the path for dimmSpd.h.

https://review.coreboot.org/#/c/19722/2/src/soc/amd/stoneyridge/smbus_spd.c
File src/soc/amd/stoneyridge/smbus_spd.c:

PS2, Line 20: #include "Porting.h"
            : #include "AGESA.h"
            : #include "amdlib.h"
            : 
            : #include <northbridge/amd/pi/dimmSpd.h>
#include <Porting.h>
#include <AGESA.h>
#include <amdlib.h>

#include <dimmSpd.h>

maybe remove blank line


-- 
To view, visit https://review.coreboot.org/19722
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88a868e654ad127be70ecc506f6b90b784f8d1b
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list