[coreboot-gerrit] Change in coreboot[master]: ec/lenovo/h8: Build h8 in romstage

Patrick Rudolph (Code Review) gerrit at coreboot.org
Thu May 18 18:15:47 CEST 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19740 )

Change subject: ec/lenovo/h8: Build h8 in romstage
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19740/1//COMMIT_MSG
Commit Message:

Line 9: Guard ramstage methods.
> Why? what is the problem if you don't guard?
It does not compile in romstage.


-- 
To view, visit https://review.coreboot.org/19740
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76dcf1fd54386562b63695003cee2956b42557c5
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list