[coreboot-gerrit] Change in coreboot[master]: detachables: Add invert parameter
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Thu May 18 08:59:10 CEST 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19698 )
Change subject: detachables: Add invert parameter
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/19698/5/payloads/libpayload/drivers/video/graphics.c
File payloads/libpayload/drivers/video/graphics.c:
PS5, Line 568: 0x000000ff
Can you define macro for this: PIVOT_MASK.
PS5, Line 569: 0x1
INVERT_MASK
PS5, Line 569: 8
INVERT_SHIFT
--
To view, visit https://review.coreboot.org/19698
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide6893a26f19eb2490377d4d53366ad145a9e6e3
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list