[coreboot-gerrit] Change in coreboot[master]: drivers/spi/spi_flash: Pass in flash structure to fill in probe

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu May 18 07:35:23 CEST 2017


Hello Aaron Durbin, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19705

to look at the new patch set (#8).

Change subject: drivers/spi/spi_flash: Pass in flash structure to fill in probe
......................................................................

drivers/spi/spi_flash: Pass in flash structure to fill in probe

Instead of making all SPI drivers allocate space for a spi_flash
structure and fill it in, udpate the API to allow callers to pass in a
spi_flash structure that can be filled by the flash drivers as
required. This also cleans up the interface so that the callers can
maintain and free the space for spi_flash structure as required.

BUG=b:38330715

Change-Id: If6f1b403731466525c4690777d9b32ce778eb563
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/cpu/amd/pi/spi.c
M src/drivers/intel/fsp1_0/fastboot_cache.c
M src/drivers/spi/adesto.c
M src/drivers/spi/amic.c
M src/drivers/spi/atmel.c
M src/drivers/spi/boot_device_rw_nommap.c
M src/drivers/spi/cbfs_spi.c
M src/drivers/spi/eon.c
M src/drivers/spi/gigadevice.c
M src/drivers/spi/macronix.c
M src/drivers/spi/spansion.c
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_flash_internal.h
M src/drivers/spi/sst.c
M src/drivers/spi/stmicro.c
M src/drivers/spi/winbond.c
M src/include/spi_flash.h
M src/northbridge/amd/agesa/oem_s3.c
M src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
M src/northbridge/intel/common/mrc_cache.c
M src/soc/broadcom/cygnus/ddr_init.c
M src/soc/intel/common/block/fast_spi/fast_spi_flash.c
M src/soc/intel/fsp_baytrail/nvm.c
M src/soc/mediatek/mt8173/flash_controller.c
M src/southbridge/intel/common/spi.c
25 files changed, 261 insertions(+), 271 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/19705/8
-- 
To view, visit https://review.coreboot.org/19705
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If6f1b403731466525c4690777d9b32ce778eb563
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list