[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Define spi_flash_ctrlr structure

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu May 18 04:54:03 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19708 )

Change subject: drivers/spi: Define spi_flash_ctrlr structure
......................................................................


Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/19708/8/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:

Line 947: int spi_setup_slave(unsigned int bus, unsigned int cs, struct spi_slave *slave)
> We use spi_setup_slave() strong symbol because we never implemented the bus
Yeah, I have that on my todo for a while.. Just haven't been able to get to it yet.


-- 
To view, visit https://review.coreboot.org/19708
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b
Gerrit-PatchSet: 8
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list