[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Define spi_flash_ctrlr structure

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu May 18 04:37:53 CEST 2017


Hello Julius Werner, build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19708

to look at the new patch set (#10).

Change subject: drivers/spi: Define spi_flash_ctrlr structure
......................................................................

drivers/spi: Define spi_flash_ctrlr structure

In order to support some specialized SPI controllers that are actually
SPI flash controllers, define a new spi_flash_ctrlr structure with the
following member:

1. probe: Specialized probe function provided by the spi flash
controller.

With this change, the specialized spi flash probe functions are now
associated with a particular spi ctrlr structure and no longer
disconnected from the spi controller.

Later, more functions will be added to spi_flash_ctrlr.

BUG=b:38330715
TEST=Verified with the entire patch series that spi flash driver still
works fine on poppy.

Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/drivers/spi/spi_flash.c
M src/include/spi-generic.h
M src/include/spi_flash.h
M src/soc/intel/apollolake/spi.c
M src/soc/intel/common/block/fast_spi/fast_spi.c
M src/soc/intel/common/block/fast_spi/fast_spi_flash.c
M src/soc/intel/common/block/include/intelblocks/fast_spi.h
M src/soc/intel/skylake/spi.c
M src/soc/mediatek/mt8173/flash_controller.c
M src/soc/mediatek/mt8173/spi.c
M src/southbridge/intel/common/spi.c
11 files changed, 89 insertions(+), 81 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/19708/10
-- 
To view, visit https://review.coreboot.org/19708
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35f3bd8ddc5e71515df3ef0c1c4b1a68ee56bf4b
Gerrit-PatchSet: 10
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list