[coreboot-gerrit] Change in coreboot[master]: amd/gardenia: Add PSP DRAM notify to romstage
Marshall Dawson (Code Review)
gerrit at coreboot.org
Thu May 18 01:43:41 CEST 2017
Marshall Dawson has uploaded a new change for review. ( https://review.coreboot.org/19754 )
Change subject: amd/gardenia: Add PSP DRAM notify to romstage
......................................................................
amd/gardenia: Add PSP DRAM notify to romstage
Change-Id: I6ccbbee00aab947079c3471fcf83ae9a66c01d59
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/mainboard/amd/gardenia/romstage.c
R src/soc/amd/common/block/include/amdblocks/psp.h
M src/soc/amd/common/block/psp/psp.c
3 files changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/19754/1
diff --git a/src/mainboard/amd/gardenia/romstage.c b/src/mainboard/amd/gardenia/romstage.c
index d58109e..788d3d7 100644
--- a/src/mainboard/amd/gardenia/romstage.c
+++ b/src/mainboard/amd/gardenia/romstage.c
@@ -24,6 +24,7 @@
#include <northbridge/amd/pi/agesawrapper.h>
#include <northbridge/amd/pi/agesawrapper_call.h>
#include <soc/hudson.h>
+#include <amdblocks/psp.h>
void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
{
@@ -64,9 +65,12 @@
AGESAWRAPPER(amdinitpost);
post_code(0x41);
- cbmem_initialize_empty();
+ psp_notify_dram();
post_code(0x42);
+ cbmem_initialize_empty();
+
+ post_code(0x43);
AGESAWRAPPER(amdinitenv);
/* TODO: Disable cache is not ok. */
disable_cache_as_ram();
diff --git a/src/soc/amd/common/block/psp/psp.h b/src/soc/amd/common/block/include/amdblocks/psp.h
similarity index 100%
rename from src/soc/amd/common/block/psp/psp.h
rename to src/soc/amd/common/block/include/amdblocks/psp.h
diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c
index c75b92f..b22161d 100644
--- a/src/soc/amd/common/block/psp/psp.c
+++ b/src/soc/amd/common/block/psp/psp.c
@@ -18,7 +18,7 @@
#include <cbmem.h>
#include <device/pci_def.h>
#include <console/console.h>
-#include "psp.h"
+#include <amdblocks/psp.h>
static const char *psp_status_nobase = "error: PSP BAR3 not assigned";
static const char *psp_status_halted = "error: PSP in halted state";
--
To view, visit https://review.coreboot.org/19754
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ccbbee00aab947079c3471fcf83ae9a66c01d59
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
More information about the coreboot-gerrit
mailing list