[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Display FPF status of CSME

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/19747 )

Change subject: soc/intel/skylake: Display FPF status of CSME
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/19747/1/src/soc/intel/skylake/me.c
File src/soc/intel/skylake/me.c:

Line 232: 	hfs6.data = me_read_config32(PCI_ME_HFSTS6);
> Dos this reflect reality? Or is this the request bit from EOM which indicat
it reflects the reality. I have confirmed from CSME team.


Line 350: 		printk(BIOS_DEBUG, "FPF not committed.\n");
> These messages should be aligned withe apololake's code, I think. That way 
Done


-- 
To view, visit https://review.coreboot.org/19747
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If63c7874e6c894749df8100426faca0ad432384b
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes