[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: remove the delay for enabling SSC

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/19699 )

Change subject: rockchip/rk3399: remove the delay for enabling SSC
......................................................................


rockchip/rk3399: remove the delay for enabling SSC

The hang was caused by deasserting the reset before, it had been delayed 20us
fixing the hang issue.

So we can remove this delay for now.

Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Signed-off-by: Caesar Wang <wxt at rock-chips.com>
Reviewed-on: https://review.coreboot.org/19699
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Julius Werner <jwerner at chromium.org>
---
M src/soc/rockchip/rk3399/clock.c
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  Julius Werner: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified



diff --git a/src/soc/rockchip/rk3399/clock.c b/src/soc/rockchip/rk3399/clock.c
index 944ca6f..7e205d2 100644
--- a/src/soc/rockchip/rk3399/clock.c
+++ b/src/soc/rockchip/rk3399/clock.c
@@ -356,11 +356,6 @@
 {
 	u32 divval;
 
-	/*
-	 * TODO find the root cause why is the delay needed, otherwise sometimes
-	 * hang somewhere with reboot tests.
-	 */
-	udelay(30);
 	assert(dpll_cfg->refdiv && dpll_cfg->refdiv <= 6);
 
 	/*

-- 
To view, visit https://review.coreboot.org/19699
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5545377b72eb20b59ceaaca25c78965854bfb919
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>