[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Display FPF status of CSME

Pratikkumar V Prajapati (Code Review) gerrit at coreboot.org
Wed May 17 23:36:14 CEST 2017


Pratikkumar V Prajapati has uploaded a new change for review. ( https://review.coreboot.org/19747 )

Change subject: soc/intel/skylake: Display FPF status of CSME
......................................................................

soc/intel/skylake: Display FPF status of CSME

Field Programmable Fuses (FPF) status maintained by
CSME in bits 30:31 of FWSTS6 for skylake and kabylake.
FPF committed means CSME has blown the fuses.

Change-Id: If63c7874e6c894749df8100426faca0ad432384b
Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati at intel.com>
---
M src/soc/intel/skylake/include/soc/me.h
M src/soc/intel/skylake/me.c
2 files changed, 26 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/19747/1

diff --git a/src/soc/intel/skylake/include/soc/me.h b/src/soc/intel/skylake/include/soc/me.h
index 8dc21c3..07c4dc5 100644
--- a/src/soc/intel/skylake/include/soc/me.h
+++ b/src/soc/intel/skylake/include/soc/me.h
@@ -186,6 +186,18 @@
 	} __attribute__ ((packed)) fields;
 };
 
+#define PCI_ME_HFSTS6			0x6c
+#define ME_HFS6_FPF_NOT_COMMITTED	0x0
+#define ME_HFS6_FPF_ERROR		0x2
+
+union me_hfs6 {
+	u32 data;
+	struct {
+	u32 reserved1: 30;
+	u32 fpf_nvars: 2;
+	} __attribute__ ((packed)) fields;
+};
+
 /*
  * Management Engine MMIO registers
  */
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index 5bc5c95..3bf061d 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -224,10 +224,12 @@
 	union me_hfs hfs;
 	union me_hfs2 hfs2;
 	union me_hfs3 hfs3;
+	union me_hfs6 hfs6;
 
 	hfs.data = me_read_config32(PCI_ME_HFSTS1);
 	hfs2.data = me_read_config32(PCI_ME_HFSTS2);
 	hfs3.data = me_read_config32(PCI_ME_HFSTS3);
+	hfs6.data = me_read_config32(PCI_ME_HFSTS6);
 
 	/* Check Current States */
 	printk(BIOS_DEBUG, "ME: FW Partition Table      : %s\n",
@@ -341,6 +343,18 @@
 				hfs3.fields.fw_sku);
 		}
 	}
+
+	printk(BIOS_DEBUG, "ME: FPF NVARs               : ");
+	switch (hfs6.fields.fpf_nvars) {
+	case ME_HFS6_FPF_NOT_COMMITTED:
+		printk(BIOS_DEBUG, "FPF not committed.\n");
+		break;
+	case ME_HFS6_FPF_ERROR:
+		printk(BIOS_DEBUG, "FPF status unknown.\n");
+		break;
+	default:
+		printk(BIOS_DEBUG, "FPF committed.\n");
+	}
 }
 
 /*

-- 
To view, visit https://review.coreboot.org/19747
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If63c7874e6c894749df8100426faca0ad432384b
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>



More information about the coreboot-gerrit mailing list