[coreboot-gerrit] Change in coreboot[master]: sb/intel/common: Add common EC fw support

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19719 )

Change subject: sb/intel/common: Add common EC fw support
......................................................................


Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/19719/3/src/southbridge/intel/common/firmware/Kconfig
File src/southbridge/intel/common/firmware/Kconfig:

PS3, Line 122: 	  The embedded controller needs a firmware file.
             : 	  Select this if you are going to use the PCH integrated controller
             : 	  and have the firmware.
> Please add a blank line between paragraphs.
Done


PS3, Line 122: 	  The embedded controller needs a firmware file.
             : 	  Select this if you are going to use the PCH integrated controller
             : 	  and have the firmware.
> Please elaborate, how the file is put into the firmware image.
Done


-- 
To view, visit https://review.coreboot.org/19719
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14732b4d263dde4770bf26b055c005de2540338
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes